-------
From: eadler@@freebsd.org
Date: Fri, 15 Mar 2013 23:42:01 GMT (Sat 00:42 CET)
To: jhs@@berklix.org, eadler@@freebsd.org, wkoszek@@freebsd.org

Synopsis: [patch] config(8): config -x appends unwanted trailing null

State-Changed-From-To: patched->closed
State-Changed-By: eadler
State-Changed-When: Fri Mar 15 23:42:01 UTC 2013
State-Changed-Why: 
MFCed/fixed by now or it will never be MFCed

http://www.freebsd.org/cgi/query-pr.cgi?pr=119610
-------
This patch has been applied & is not need for 8.0-RELEASE

This patch does not apply to end of kernconf() in 7.4-RELEASE
looks like the code gas been rewritten.
Also config -x /boot/kernel/kernel creates no null byte.

http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/119610

Assume not needed for 6.3, as config -x /boot/kernel/kernel reports
illegal option -- x


To: FreeBSD-gnats-submit@@freebsd.org
From: Julian H. Stacey <jhs@@berklix.com>
Cc: Julian H. Stacey <jhs@@berklix.com>
X-send-pr-version: 3.113
X-GNATS-Notify: 


>Submitter-Id:	current-users
>Originator:	Julian H. Stacey <jhs@@berklix.com>
>Organization:	http://www.berklix.com
>Confidential:	no <FreeBSD PRs are public data>
>Synopsis:	config -x appends unwanted trailing null, patched
>Severity:	non-critical 
>Priority:	medium 
>Category:	bin
>Class:		change-request 
>Release:	FreeBSD 7.0-PRERELEASE i386
>Environment:
System: FreeBSD lapd.js.berklix.net 7.0-PRERELEASE FreeBSD 7.0-PRERELEASE #82: Sat Jan 12 13:14:16 CET 2008 jhs@@lapd.js.berklix.net:/usr/src/sys/i386/compile/LAPD.small i386


	<machine, os, target, libraries (multiple lines)>
>Description:
	config -x appends unwanted trailing null
	avoid it, as it upsets tools such as diff when comparing similar configs
	
>How-To-Repeat:
	config -x /boot/kernel/kernel > t
	vi t
	:$
>Fix:

	<how to correct or work around the problem, if known (multiple lines)>

http://www.berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/usr.sbin/config/main.c.REL=ALL.diff


*** 7.0-PRERELEASE-src-7-ctm86/src/usr.sbin/config/main.c	Sat Jan 12 23:02:26 2008
--- new/src/usr.sbin/config/main.c	Sat Jan 12 23:10:48 2008
***************
*** 687,693 ****
  	r = fseek(fp, off, SEEK_CUR);
  	if (r != 0)
  		errx(EXIT_FAILURE, "fseek() failed");
! 	while ((r = fgetc(fp)) != EOF && size-- > 0)
  		fputc(r, stdout);
  	fclose(fp);
  }
--- 687,693 ----
  	r = fseek(fp, off, SEEK_CUR);
  	if (r != 0)
  		errx(EXIT_FAILURE, "fseek() failed");
! 	while ((r = fgetc(fp)) != EOF && ( r != '\0' ) && size-- > 0)
  		fputc(r, stdout);
  	fclose(fp);
  }
-------------------------------
From gavin@@FreeBSD.org Sun Jan  3 14:25:09 2010
Date: Sun, 3 Jan 2010 13:20:27 GMT
Message-Id: <201001031320.o03DKRgN030027@@freefall.freebsd.org>
To: jhs@@berklix.org, gavin@@FreeBSD.org, freebsd-bugs@@FreeBSD.org,
        wkoszek@@FreeBSD.org
From: gavin@@FreeBSD.org
Subject: Re: bin/119610: [patch] config(8): config -x appends unwanted trailing null

Synopsis: [patch] config(8): config -x appends unwanted trailing null

State-Changed-From-To: open->patched
State-Changed-By: gavin
State-Changed-When: Sun Jan 3 13:18:47 UTC 2010
State-Changed-Why: 
This was fixed in HEAD (and therefore in 8.x) in r188214 but
has not been MFC'd to 7.x


Responsible-Changed-From-To: freebsd-bugs->wkoszek
Responsible-Changed-By: gavin
Responsible-Changed-When: Sun Jan 3 13:18:47 UTC 2010
Responsible-Changed-Why: 
Over to wkoszek, committer of r188214, for MFC consideration

http://www.freebsd.org/cgi/query-pr.cgi?pr=119610


------- End of Forwarded Message