From jhs@@@berklix.com Tue Nov 1 01:30:12 2011 Date: Tue, 1 Nov 2011 02:27:04 +0100 (CET) To: FreeBSD-gnats-submit@@@freebsd.org Subject: regression bug in calendar 8.2, 8-stable & current, OK in 8.1 & 7.4 & 6.4 From: "Julian H. Stacey" cc: "Julian H. Stacey" , edwin@@@freebsd.org Reply-To: "Julian H. Stacey" >Submitter-Id: current-users >Originator: Julian H. Stacey >Organization: http://www.berklix.com BSD Linux Unix Consultancy, Munich/Muenchen. >Confidential: no >Synopsis: regression bug in calendar 8.2, 8-stable & current, OK in 8.1 & 7.4 & 6.4 >Severity: serious >Priority: medium >Category: bin >Class: sw-bug >Release: FreeBSD 8.2-RELEASE amd64 >Environment: System: FreeBSD fire.js.berklix.net 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Jun 2 23:10:13 CEST 2011 jhs@@@blak.js.berklix.net:/ad6s4/release/8.2-RELEASE/src/sys/amd64/compile/FIRE64.small amd64 >Description: User groups rely on calendar meeting dates such as 1st Tuesday, 3rd Wednesday, Last Sunday each month. That broke in 8.2-RELEASE & 8-stable & current >How-To-Repeat: date # Tue Nov 1 ....... echo > ~/tmp/calendar_test_data << EOF /* caution tabs in here so do not mouse copy */ Tuesday+1 first Tuesday in month Wednesday Midweek Thursday-1 last Thursday in month EOF 7.4 & 8.1-RELEASE: calendar -f ~/tmp/calendar_test_data Nov 1* first Tuesday in month Nov 2* Midweek 8.2-RELEASE & 8-stable & current Unprocessed: ------- date: |Tuesday+1| flags: 10a - dayofweek modifierindex variable modifierindex: |+1| dayofweek: |Tuesday| (2) Ignored: Tuesday+1 first Tuesday in month Unprocessed: ------- date: |Thursday-1| flags: 10a - dayofweek modifierindex variable modifierindex: |-1| dayofweek: |Thursday| (4) Ignored: Thursday-1 last Thursday in month Nov 2* Midweek PS Some other good & bad patterns I tried : /* 8.2 * /Friday testtest Result: Emits nothing*/ /* 8.2 * /Friday-1 testtest Result: Emits nothing */ /* 8.2 * Friday testtest Result: OK Emits */ /* 8.2 * Friday-0 testtest Result: Emits nothing*/ /* 8.2 * Friday-1 testtest Result: Emits nothing*/ /* 8.2 * Friday-2 testtest Result: Emits nothing*/ /* 8.2 *''/Friday testtest Result: Emits nothing*/ /* 8.2 *''/Friday+1 testtest Result: Emits nothing*/ /* 8.2 *''/Friday-0 testtest Result: Emits nothing*/ /* 8.2 *''/Friday-1 testtest Result: Emits nothing*/ /* 8.2 2011/10/27 testtest Result: OK Emits */ /* 8.2 Friday testtest Result: OK Emits */ /* 8.2 Friday +1 testtest Result: Emits nothing*/ /* 8.2 Friday+1 testtest Result: Errors, and says Ignored*/ /* 6.4 Friday-1 testtest Result: OK Emits */ /* 8.2 Friday-1 testtest Result: Errors, and says Ignored*/ /* 8.2 Oct Friday -1 testtest Result: Emits nothing */ /* 8.2 Oct Friday-1 testtest Result: Emits nothing*/ >Fix: https://svnweb.freebsd.org/base/head/usr.bin/calendar/calendar.c?view=log shows edwin@@@ was last person interested in calendar.c Mon Aug 23 22:09:25 2010 UTC ... r205821: Long awaited update to the calendar system: - Repeating events ... so FYI cc'd him as hopefully he's familiar with sources. =============================================================================== Subject: Re: bin/162211: regression bug in calendar 8.2, 8-stable & current, OK in 8.1 & 7.4 & 6.4 From: FreeBSD-gnats-submit@@@FreeBSD.org Date: Tue, 1 Nov 2011 02:00:24 GMT (03:00 CET) To: "Julian H. Stacey" Thank you very much for your problem report. It has the internal identification `bin/162211'. The individual assigned to look at your report is: freebsd-bugs. You can access the state of your problem report at any time via this link: http://www.freebsd.org/cgi/query-pr.cgi?pr=162211 >Category: bin >Responsible: freebsd-bugs >Synopsis: regression bug in calendar 8.2, 8-stable & current, OK in 8.1 & 7.4 & 6.4 >Arrival-Date: Tue Nov 01 02:00:24 UTC 2011 =============================================================================== From tim@@@wideblueocean.com Tue Jul 17 10:45:06 2012 From: Tim Hogard Content-Type: text/plain; charset=us-ascii Subject: Calendar bug for first and last dates - 162211 Date: Tue, 17 Jul 2012 17:34:57 +1000 Message-Id: To: jhs@@@berklix.com Mime-Version: 1.0 (Apple Message framework v1084) X-Mailer: Apple Mail (2.1084) Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by fire.js.berklix.net id q6H8j13s035614 Did you ever find a solution? I don't think this is a trivial thing to fix because there have been bugs on what if its with the +2 notation since 6.4 but at least 6.4 worked sometimes and didn't complain when it broke. I suspect someone needs to rewrite that code. -tim =============================================================================== To: Tim Hogard cc: edwin@freebsd.org Subject: Re: Calendar bug for first and last dates - 162211 From: "Julian H. Stacey" Organization: http://www.berklix.com BSD Unix Linux Consultancy, Munich Germany Fcc: sent User-agent: EXMH on FreeBSD http://www.berklix.com/free/ X-URL: http://www.berklix.com In-reply-to: Your message "Tue, 17 Jul 2012 17:34:57 +1000." Hi Tim cc added edwin@ Tim Hogard wrote: > Did you ever find a solution? I just checked http://www.freebsd.org/cgi/query-pr.cgi?pr=162211&cat=src & my log: http://www.berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/usr.bin/calendar/send-pr.first_last_in_month.no_customise No solution. > I don't think this is a trivial thing to fix because there have been bugs on what if its with the +2 notation since 6.4 but at least 6.4 worked sometimes and didn't complain when it broke. > > I suspect someone needs to rewrite that code. Yes, Ditto. > -tim I dont know where code comes from but I added edwin@freebsd.org Maybe we should either: - revert to older working code, or - import from newer source, if it exists I guess we share (or should) calendar with other BSDs ? Cheers, Julian =============================================================================== From tim@@@wideblueocean.com Tue Jul 17 13:10:12 2012 Cc: edwin@@@freebsd.org Message-Id: <99DDE98F-EF9F-4EBF-B76C-BC1AC22E31A6@@@wideblueocean.com> From: Tim Hogard To: "Julian H. Stacey" In-Reply-To: <201207170910.q6H9AM34049335@@@fire.js.berklix.net> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v936) Subject: Re: Calendar bug for first and last dates - 162211 Date: Tue, 17 Jul 2012 21:04:04 +1000 References: <201207170910.q6H9AM34049335@@@fire.js.berklix.net> X-Mailer: Apple Mail (2.936) On Jul 17, 2012, at 7:10 PM, Julian H. Stacey wrote: > Hi Tim > cc added edwin@@@ > > Tim Hogard wrote: >> Did you ever find a solution? > > I just checked > http://www.freebsd.org/cgi/query-pr.cgi?pr=162211&cat=src > > & my log: > http://www.berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/usr.bin/calendar/send-pr.first_last_in_month.no_customise > > No solution. I agree. > >> I don't think this is a trivial thing to fix because there have >> been bugs on what if its with the +2 notation since 6.4 but at >> least 6.4 worked sometimes and didn't complain when it broke. >> >> I suspect someone needs to rewrite that code. > > Yes, Ditto. > >> -tim > > I dont know where code comes from but I added edwin@@@freebsd.org > Maybe we should either: > - revert to older working code, or > - import from newer source, if it exists > I guess we share (or should) calendar with other BSDs ? I disagree with reverting because the old code doesn't work, it just doesn't complain when it fails and I think that is worse than its current state. Is there any newer? What do Drangonfly, openBSD and netBSD do? Thanks, -tim ===============================================================================