http://lists.freebsd.org/pipermail/freebsd-hackers/2011-January/034254.html From owner-freebsd-hackers@@@freebsd.org Tue Feb 1 00:10:15 2011 Message-Id: <201101312218.p0VMIs90003417@@@fire.js.berklix.net> To: hackers@@@freebsd.org, netbsd-users@@@NetBSD.org From: "Julian H. Stacey" Organization: http://www.berklix.com BSD Linux Unix Consultancy, Munich Germany User-agent: EXMH on FreeBSD http://www.berklix.com/free/ X-URL: http://www.berklix.com/~jhs/cv/ Date: Mon, 31 Jan 2011 23:18:54 +0100 Cc: Subject: usr.bin/tar/ ignores error codes from read() just silently pads nulls X-BeenThere: freebsd-hackers@@@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Archive: List-Post: List-Help: List-Subscribe: , Sender: owner-freebsd-hackers@@@freebsd.org Errors-To: owner-freebsd-hackers@@@freebsd.org Hi hackers@@@freebsd.org & netbsd-users@@@NetBSD.org usr.bin/tar ignores device error codes from read() & silently pads nulls. See FreeBSD 6.2 6.4 7.3, 8.0, 8.1, & current src/usr.bin/tar/write.c NetBSD 5.1 & current src/external/bsd/libarchive/dist/tar/write.c ^write_file_data( last 3 lines ... bytes_read = read I filed a send-pr yesterday Mon, 31 Jan 2011 04:52:29 +0100 (CET) http://www.freebsd.org/cgi/query-pr.cgi?pr=154407 diffs slightly cleaned up here: http://www.berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/usr.bin/tar/ Tar author will probably issue cleaner code as soon as he has time. Meantime, if you may have copied in data without realising media was flakey, bsdtar will not have warned (though /var/log/messages does), so you may want to scan with find & a detector eg http://www.berklix.com/~jhs/src/bsd/jhs/bin/public/8f/ Cheers, Julian -- Julian H. Stacey, BSD Unix Linux C Sys Eng Consultants Munich http://www.berklix.com Mail plain text; Not quoted-printable, Not HTML, Not base 64. Reply below text sections not at top, to avoid breaking cumulative context. _______________________________________________ freebsd-hackers@@@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@@@freebsd.org"